Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Line Chart Annotation Info Update #19001

Merged
merged 6 commits into from
Apr 14, 2022
Merged

fix: Line Chart Annotation Info Update #19001

merged 6 commits into from
Apr 14, 2022

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

In production annotation verbiage is a bit confusing for a new user.
Feedback from Opendoor was to clarify that the chart being referenced is a chart created by the user/team.

Clear instruction should be needed.

Use another existing chart as a source for annotations and overlays.
Your chart must be one of these visualization types:...

image

@codemaster08240328 codemaster08240328 changed the title Fix: Line Chart Annotation Info Update fix: Line Chart Annotation Info Update Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022 •
edited
Loading

Codecov Report

Merging #19001 (515690c) into master (9a9e3b6) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 515690c differs from pull request most recent head f164870. Consider uploading reports for the commit f164870 to get more accurate results

@@            Coverage Diff             @@
##           master   #19001      +/-   ##
==========================================
- Coverage   66.49%   66.32%   -0.17%     
==========================================
  Files        1681     1681              
  Lines       64370    64370              
  Branches     6583     6583              
==========================================
- Hits        42803    42695     -108     
- Misses      19886    19994     +108     
  Partials     1681     1681
Flag Coverage Δ
hive ?
mysql 81.89% <ø> (ø)
postgres 81.94% <ø> (ø)
presto ?
python 82.03% <ø> (-0.35%) ⬇️
sqlite 81.71% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrols/AnnotationLayerControl/AnnotationLayer.jsx 74.39% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.11% <0.00%> (-15.71%) ⬇️
superset/db_engine_specs/presto.py 83.64% <0.00%> (-5.39%) ⬇️
superset/connectors/sqla/models.py 88.24% <0.00%> (-1.22%) ⬇️
superset/initialization/__init__.py 91.31% <0.00%> (-0.35%) ⬇️
superset/db_engine_specs/base.py 88.01% <0.00%> (-0.34%) ⬇️
superset/models/core.py 88.83% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.71% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a9e3b6...f164870. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 8, 2022
@rusackas rusackas self-requested a review March 10, 2022 04:22
rusackas
rusackas approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hopefully the CI Logjam will clear soon :)

@rusackas
Copy link
Member

@codemaster08240328 please rebase so this can pass CI.

@yousoph yousoph merged commit ac2c66c into apache:master Apr 14, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@codemaster08240328 @philipher29
fix: Line Chart Annotation Info Update (apache#19001)
1e243f1 
* fix Line Chart Annotation Info Updage

* wrap annotation text with transation

* resolve comment
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomedina248 diegomedina248 diegomedina248 approved these changes

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codemaster08240328 @rusackas @diegomedina248 @mistercrunch @yousoph