fix(explore-sqllab): make that Timestamp column keep the Is temporal …

[prosdev0107]

SUMMARY

Overwriting an existing virtual dataset removes the Is temporal flag from columns

How to reproduce the bug

1. Navigate to the SQL Lab.
2. Run a SELECT statement including a timestamp column.
3. Click on EXPLORE.
4. Create a new dataset.
5. Note that the timestamp column is available to be selected on the time column drop-down.
6. Navigate back to the SQL Lab.
7. Run the same query again.
8. Click on EXPLORE.
9. Choose to overwrite the dataset you have just created.
10. Note that the timestamp column is not available to be used on the time column drop-down.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

AFTER:

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19010 (de3dc69) into master (be88cb9) will increase coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #19010      +/-   ##
==========================================
+ Coverage   66.58%   66.78%   +0.20%     
==========================================
  Files        1641     1643       +2     
  Lines       63548    65287    +1739     
  Branches     6424     7064     +640     
==========================================
+ Hits        42312    43603    +1291     
- Misses      19555    19936     +381     
- Partials     1681     1748      +67     

Flag	Coverage Δ
javascript	52.42% <0.00%> (+1.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx	50.73% <0.00%> (ø)
...ts/nativeFilters/FilterBar/FilterControls/utils.ts	57.14% <0.00%> (-12.86%)	⬇️
...Filters/FilterBar/FilterControls/FilterControl.tsx	77.35% <0.00%> (-4.79%)	⬇️
...oard/components/nativeFilters/FilterCard/Styles.ts	80.00% <0.00%> (-4.62%)	⬇️
...d/components/nativeFilters/FilterCard/ScopeRow.tsx	69.56% <0.00%> (-3.17%)	⬇️
...perset-frontend/src/addSlice/AddSliceContainer.tsx	58.62% <0.00%> (-3.15%)	⬇️
superset-frontend/src/explore/controls.jsx	27.94% <0.00%> (-3.10%)	⬇️
...et-frontend/src/explore/controlPanels/sections.tsx	83.33% <0.00%> (-2.39%)	⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	57.62% <0.00%> (-1.39%)	⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	76.56% <0.00%> (-1.02%)	⬇️
... and 56 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be88cb9...de3dc69. Read the comment docs.

[rusackas]

It might be use to add repro steps to the PR description for historical purposes, and for anyone who wants to review/test. In this case:

1. Navigate to the SQL Lab.
2. Run a SELECT statement including a timestamp column.
3. Click on EXPLORE.
4. Create a new dataset.
5. Note that the timestamp column is available to be selected on the time column drop-down.
6. Navigate back to the SQL Lab.
7. Run the same query again.
8. Click on EXPLORE.
9. Choose to overwrite the dataset you have just created.
10. Note that the timestamp column is not available to be used on the time column drop-down.

Also, is it possible to add a test for this?

[prosdev0107]

It might be use to add repro steps to the PR description for historical purposes, and for anyone who wants to review/test. In this case:

1. Navigate to the SQL Lab.
2. Run a SELECT statement including a timestamp column.
3. Click on EXPLORE.
4. Create a new dataset.
5. Note that the timestamp column is available to be selected on the time column drop-down.
6. Navigate back to the SQL Lab.
7. Run the same query again.
8. Click on EXPLORE.
9. Choose to overwrite the dataset you have just created.
10. Note that the timestamp column is not available to be used on the time column drop-down.

Also, is it possible to add a test for this?

[prosdev0107]

@evans
I just updated the columns of request params in the update the dataset api of superset.
And now the unit test isn't developed for this and so I am wondering if I can add the unit test for this.

[rusackas]

/testenv up

[github-actions]

@rusackas Ephemeral environment spinning up at http://52.13.4.148:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[rusackas]

In this PR, there seems to be a regression, with the following steps:

1. I pick a dataset, like cleaned_sales_data
2. I can open that in explore, and verify that order_date is available in the Time section of the controls as the Time Column
3. I go to SQL Editor, and do SELECT * from cleaned_sales_data
4. I click the Explore button, and save the dataset along the way
5. In the Time section, the order_date field is no longer available in the Time Column input

[rusackas]

I meant for that last comment to be a change request, not an approval 🤦

[prosdev0107]

@rusackas .
I followed the steps in last comment but I am not able to reproduce it.
And so I like to share the my screen recording file.
https://drive.google.com/file/d/1Y8p7bqvrWnk7KlqjPC4I5lfrHemSEwOO/view?usp=sharing

[rusackas]

Interesting. I'm able to reproduce on the ephemeral environment, but not when I check out the PR to my local env. I seem to recall some changes being made to the ephemeral env configuration since this was opened, so I'll trust the local testing a little more and approve this :D

[rusackas]

LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[zhaoyongjie]

seems like is_dttm and is_date is inconsistency... Let me look at more.