Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change case for upload selection #19021

Merged
merged 2 commits into from
Mar 4, 2022
Merged

chore: change case for upload selection #19021

merged 2 commits into from
Mar 4, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Mar 3, 2022

SUMMARY

Change case and sentence structure for upload selection in the dropdown.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Screen Shot 2022-03-03 at 1 05 35 PM

after
Screen Shot 2022-03-03 at 1 09 50 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson requested a review from hughhhh March 3, 2022 21:10
@codecov
Copy link

codecov bot commented Mar 3, 2022 •
edited
Loading

Codecov Report

Merging #19021 (d03430b) into master (5a8eb09) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19021      +/-   ##
==========================================
- Coverage   66.57%   66.57%   -0.01%     
==========================================
  Files        1641     1641              
  Lines       63553    63544       -9     
  Branches     6428     6425       -3     
==========================================
- Hits        42313    42307       -6     
+ Misses      19560    19557       -3     
  Partials     1680     1680
Flag Coverage Δ
javascript 51.37% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/components/MenuRight.tsx 72.13% <ø> (ø)
...d/src/filters/components/Time/TimeFilterPlugin.tsx 53.33% <0.00%> (-2.92%) ⬇️
...et-frontend/src/explore/controlPanels/sections.tsx 85.71% <0.00%> (ø)
...nd/src/dashboard/components/nativeFilters/utils.ts 46.66% <0.00%> (ø)
...d/packages/superset-ui-core/src/query/constants.ts 100.00% <0.00%> (ø)
...ckages/superset-ui-core/src/query/extractExtras.ts 100.00% <0.00%> (ø)
.../superset-ui-core/src/query/types/QueryFormData.ts 100.00% <0.00%> (ø)
...perset-ui-chart-controls/src/sections/sections.tsx 100.00% <0.00%> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx 40.86% <0.00%> (ø)
...ontrols/DateFilterControl/utils/dateFilterUtils.ts 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8eb09...d03430b. Read the comment docs.

AAfghahi
AAfghahi approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@AAfghahi AAfghahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a columnar

@pkdotson
Copy link
Member Author

pkdotson commented Mar 3, 2022

What is a columnar

a columnar file formats store data by column, not by row. CSV, TSV, JSON, are traditional row-based file formats

eschutho
eschutho approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@pkdotson pkdotson merged commit 299b5dc into apache:master Mar 4, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.9

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 4, 2022
@pkdotson @sadpandajoe
chore: change case for upload selection (apache#19021)
593c271 
* chore: change case for upload selection

* fix label

(cherry picked from commit 299b5dc)
villebro pushed a commit that referenced this pull request Apr 3, 2022
@pkdotson @villebro
chore: change case for upload selection (#19021)
073be5d 
* chore: change case for upload selection

* fix label

(cherry picked from commit 299b5dc)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AAfghahi AAfghahi AAfghahi approved these changes

@eschutho eschutho eschutho approved these changes

@hughhhh hughhhh Awaiting requested review from hughhhh

@lyndsiWilliams lyndsiWilliams Awaiting requested review from lyndsiWilliams

@yousoph yousoph Awaiting requested review from yousoph

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.9 preset-io size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pkdotson @sadpandajoe @eschutho @AAfghahi @mistercrunch @villebro