Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(explore): Set Drag&Drop feature flags to True by default #19046

Merged
merged 2 commits into from
Mar 8, 2022
Merged

chore(explore): Set Drag&Drop feature flags to True by default #19046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d11359
chore(explore): Set Drag&Drop feature flags to True by default
kgabryje Mar 7, 2022
e4f1686
fix tests
kgabryje Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset-frontend/cypress-base/cypress/integration/explore/AdhocMetrics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('AdhocMetrics', () => {
.click();

cy.get('[data-test=metrics]')
.find('[data-test="add-metric-button"]')
.contains('Drop columns/metrics here or click')
.click();

// Title edit for saved metrics is disabled - switch to Simple
Expand Down
11 changes: 7 additions & 4 deletions superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,13 @@ describe('Groupby control', () => {
cy.visitChartByName('Num Births Trend');
cy.verifySliceSuccess({ waitAlias: '@chartData' });

cy.get('[data-test=groupby]').within(() => {
cy.get('.ant-select').click();
cy.get('input[type=search]').type('state{enter}');
});
cy.get('[data-test=groupby]')
.contains('Drop columns here or click')
.click();
cy.get('[id="adhoc-metric-edit-tabs-tab-simple"]').click();
cy.get('input[aria-label="Column"]').click().type('state{enter}');
cy.get('[data-test="ColumnEdit#save"]').contains('Save').click();

cy.get('button[data-test="run-query-button"]').click();
cy.verifySliceSuccess({ waitAlias: '@chartData', chartSelector: 'svg' });
});
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/cypress-base/cypress/integration/explore/visualizations/line.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('Visualization > Line', () => {
cy.get('.text-danger').contains('Metrics');

cy.get('[data-test=metrics]')
.find('[data-test="add-metric-button"]')
.contains('Drop columns/metrics here or click')
.click();

// Title edit for saved metrics is disabled - switch to Simple
Expand Down
1 change: 1 addition & 0 deletions ...t-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ const ColumnSelectPopover = ({
}
buttonSize="small"
onClick={onSave}
data-test="ColumnEdit#save"
cta
>
{t('Save')}
Expand Down
4 changes: 2 additions & 2 deletions superset/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,9 +416,9 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
# Enable experimental feature to search for other dashboards
"OMNIBAR": False,
"DASHBOARD_RBAC": False,
"ENABLE_EXPLORE_DRAG_AND_DROP": False,
"ENABLE_EXPLORE_DRAG_AND_DROP": True,
"ENABLE_FILTER_BOX_MIGRATION": False,
"ENABLE_DND_WITH_CLICK_UX": False,
"ENABLE_DND_WITH_CLICK_UX": True,
# Enabling ALERTS_ATTACH_REPORTS, the system sends email and slack message
# with screenshot and link
# Disables ALERTS_ATTACH_REPORTS, the system DOES NOT generate screenshot
Expand Down