-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW #19054
fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW #19054
Conversation
…imited by DISPLAY_MAX_ROW
/testenv up |
@yousoph Container image not yet published for this PR. Please try again when build is complete. |
@yousoph Ephemeral environment creation failed. Please check the Actions logs for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
Codecov Report
@@ Coverage Diff @@
## master #19054 +/- ##
==========================================
- Coverage 66.52% 66.52% -0.01%
==========================================
Files 1641 1641
Lines 63476 63477 +1
Branches 6444 6445 +1
==========================================
Hits 42227 42227
Misses 19585 19585
- Partials 1664 1665 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://35.88.190.5:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and seems to work well in testing!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
When the row count of a query executed in the SQL Lab is greater than the
DISPLAY_MAX_ROW
config, the row count shows incorrectly in the Query History tab.The expected result is the row count to show the actual number of rows queried, regardless of the
DISPLAY_MAX_ROW
config, since that's only used to limit the result display.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
SELECT country_name from wb_health_population
for example) with more than 10k rowsSELECT * from wb_health_population
)It might be needed to try this a couple of times to reproduce the issue
ADDITIONAL INFORMATION