Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): import handle missing excluded charts #19088

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Mar 9, 2022

SUMMARY

This PR extends the awesome work in #18562 by removing excluded charts from native filter configurations during importing. This can happen if a chart that was present when a native filter scope was defined is later removed from the dashboard.

TESTING INSTRUCTIONS

  1. Import the exported dashboard from this PR: perf(dashboard): Improve performance of complex dashboards #19064
  2. See the KeyError that's raised (with this change the import is successful)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #19088 (393d6a2) into master (220c461) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19088   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1643     1643           
  Lines       63473    63473           
  Branches     6454     6454           
=======================================
  Hits        42218    42218           
  Misses      19585    19585           
  Partials     1670     1670           
Flag Coverage Δ
hive 52.59% <ø> (ø)
mysql 81.82% <ø> (ø)
postgres 81.87% <ø> (ø)
presto 52.44% <ø> (ø)
python 82.30% <ø> (ø)
sqlite 81.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/commands/importers/v1/utils.py 84.93% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 220c461...393d6a2. Read the comment docs.

@villebro villebro merged commit 999c2c6 into apache:master Mar 10, 2022
villebro added a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants