Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sqllab): Add a configuration option to disable data preview #19104

Merged
merged 21 commits into from
Mar 17, 2022
Merged

feat(sqllab): Add a configuration option to disable data preview #19104

merged 21 commits into from
Mar 17, 2022

Commits on May 22, 2021

  1. feat(sqllab) Add a configuration option to disable data preview 

    This setting is per-database in the "extra" JSON data.
    @akedrou
    akedrou committed May 22, 2021
    Configuration menu
    Copy the full SHA
    6cc44c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Initial commit to fix merge issues, still need to go through and make… 

    … sure the code is compatible with master
    @cccs-Dustin
    cccs-Dustin committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    2cfe589 View commit details
    Browse the repository at this point in the history

  2. Added in modifications to allow for the old PR feature to be compatib… 

    …le with master
    @cccs-Dustin
    cccs-Dustin committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    ad29be6 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Fixed some issues that were caused by the merge conficts

    @cccs-Dustin
    cccs-Dustin committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    bf2174b View commit details
    Browse the repository at this point in the history

  2. Modified the code to fix the problem where some of the tests were fai… 

    …ling
    @cccs-Dustin
    cccs-Dustin committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    b748285 View commit details
    Browse the repository at this point in the history

  3. Ran pre-commit hook to remove any issues it would pick up

    @cccs-Dustin
    cccs-Dustin committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    8eb76a9 View commit details
    Browse the repository at this point in the history

  4. Fixed a pylint error where a line was too long

    @cccs-Dustin
    cccs-Dustin committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    fb1343b View commit details
    Browse the repository at this point in the history

  5. Fixed the test so it no longer fails, since it was looking for 7 chec… 

    …kboxes and tooltips but there are now 8
    @cccs-Dustin
    cccs-Dustin committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    f91c691 View commit details
    Browse the repository at this point in the history

  6. Fixed the test so it no longer fails, since it was looking for 7 chec… 

    …kboxes and tooltips but there are now 8
    @cccs-Dustin
    cccs-Dustin committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    8459ad6 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Updated files to include the recommendations Ville made in comments o… 

    …n the PR. The largest change was reversing the flag from 'allows_preview_data' to 'disable_preview_data'. This required changes to a lot of the files, as well as I needed to reverse the expected boolean values on some of the tests
    @cccs-Dustin
    cccs-Dustin committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    a9ea6f2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'apache:master' into update-configure-data-preview

    @cccs-Dustin
    cccs-Dustin authored Mar 8, 2022
    Configuration menu
    Copy the full SHA
    ece5752 View commit details
    Browse the repository at this point in the history

  3. Fixed the disable_preview_data function so that if a 'trash value' st… 

    …ring is passed into the parameter instead of a boolean value, it will return False
    @cccs-Dustin
    cccs-Dustin committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    6bb15c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Merge branch 'apache:master' into update-configure-data-preview

    @cccs-Dustin
    cccs-Dustin authored Mar 9, 2022
    Configuration menu
    Copy the full SHA
    675d031 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Merge branch 'apache:master' into update-configure-data-preview

    @cccs-Dustin
    cccs-Dustin authored Mar 10, 2022
    Configuration menu
    Copy the full SHA
    d6a36b8 View commit details
    Browse the repository at this point in the history

  2. Minor modification to correct an error pointed out by prettier/prettier

    @cccs-Dustin
    cccs-Dustin committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    75b6067 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'update-configure-data-preview' of github.com:Cybercentr… 

    …eCanada/superset into update-configure-data-preview
    @cccs-Dustin
    cccs-Dustin committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    f374667 View commit details
    Browse the repository at this point in the history

  4. Fixed an error detected by pylint

    @cccs-Dustin
    cccs-Dustin committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    ac3df14 View commit details
    Browse the repository at this point in the history

  5. Ran the pre-commit hook

    @cccs-Dustin
    cccs-Dustin committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    f7312b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Updated tooltip text, as well as changed the 'disable_preview_data' f… 

    …lag to be named 'disable_data_preview'
    @cccs-Dustin
    cccs-Dustin committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    bb4974f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'apache:master' into update-configure-data-preview

    @cccs-Dustin
    cccs-Dustin authored Mar 15, 2022
    Configuration menu
    Copy the full SHA
    b5aeac2 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Merge branch 'apache:master' into update-configure-data-preview

    @cccs-Dustin
    cccs-Dustin authored Mar 17, 2022
    Configuration menu
    Copy the full SHA
    b5b43d4 View commit details
    Browse the repository at this point in the history