Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: SQLLAB_BACKEND_PERSISTENCE to True by default #19147

Closed
wants to merge 1 commit into from

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 15, 2022

SUMMARY

Set SQLLAB_BACKEND_PERSISTENCE to True by default

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh
Copy link
Member Author

hughhhh commented Mar 15, 2022

@ktmud does airbnb have this one by default already? We want to make sure we aren't forcing a breaking change on your end.

@ktmud
Copy link
Member

ktmud commented Mar 15, 2022

No, we don't have it turned on yet and I'm working on this, too: #19107

There seems to be some tests broken.

@hughhhh hughhhh changed the title chore: SQLLAB_BACKEND_PERSISTENCE to True by default chore!: SQLLAB_BACKEND_PERSISTENCE to True by default Mar 15, 2022
@hughhhh hughhhh added the v2.0 label Mar 15, 2022
@hughhhh hughhhh closed this Mar 15, 2022
@mistercrunch mistercrunch deleted the set-SQLLAB_BACKEND_PERSISTENCE-true branch March 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants