-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): make to consider the case sensitive in case of d3 format selector #19159
Conversation
Instead of adding yet another config option, how about just passing
|
@ktmud |
Codecov Report
@@ Coverage Diff @@
## master #19159 +/- ##
==========================================
- Coverage 66.73% 66.73% -0.01%
==========================================
Files 1668 1668
Lines 64271 64273 +2
Branches 6496 6498 +2
==========================================
Hits 42894 42894
- Misses 19695 19697 +2
Partials 1682 1682
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
d3 format selection widgets should use case sensitive matching for determining uniqueness #17716
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
How to reproduce the bug
ADDITIONAL INFORMATION