-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add missing keys in components inside lists #19161
chore: add missing keys in components inside lists #19161
Conversation
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
Show resolved
Hide resolved
a2adb93
to
d78c249
Compare
Codecov Report
@@ Coverage Diff @@
## master #19161 +/- ##
==========================================
- Coverage 66.54% 66.52% -0.03%
==========================================
Files 1646 1645 -1
Lines 63630 63655 +25
Branches 6475 6484 +9
==========================================
+ Hits 42343 42345 +2
- Misses 19607 19629 +22
- Partials 1680 1681 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the patience and due diligence.
(cherry picked from commit 54f1b35)
SUMMARY
Components inside react lists must have their own unique keys.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION