-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade mypy check in pre-commit #19227
Conversation
❗ Please consider rebasing your branch to avoid db migration conflicts. |
a788c6e
to
7c71093
Compare
Codecov Report
@@ Coverage Diff @@
## master #19227 +/- ##
===========================================
+ Coverage 52.11% 66.74% +14.62%
===========================================
Files 1666 1668 +2
Lines 64197 64279 +82
Branches 6496 6496
===========================================
+ Hits 33458 42901 +9443
+ Misses 29057 19696 -9361
Partials 1682 1682
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
7c71093
to
8542eaa
Compare
(cherry picked from commit 92cd0a1)
SUMMARY
CI for pre-commit is suddenly failing. #19156 bypassed it by fixing the error as the
mypy
hook in pre-commit suggests, but the same error was not reproducible locally. Let's just upgrade the mypy hook to see if the inconsistency between CI and local env persists.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION