-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: SECRET_KEY Rotation Documentation #19233
Conversation
Additional documentation for SECRET_KEY rotation and SECRET_KEY setting up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, thank you for your contribution!
# Your App secret key, this will be used for encrypting the data. | ||
# Make sure you are changing this key for your deployment with a strong key. | ||
# You can generate a strong key using `openssl rand -base64 42` | ||
|
||
SECRET_KEY = '\2\1thisismyscretkey\1\2\e\y\y\h' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this default on the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Bumped the helm chart version for the new changes.
Removed the default secret key value from the configuration docs.
LGTM is it ready to go @sujiplr ? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, I'm sure this will be very helpful to lots of people!
* SECRET_KEY Rotation Additional documentation for SECRET_KEY rotation and SECRET_KEY setting up. * Bumped the helm chart version to 0.5.11 Bumped the helm chart version for the new changes. * Removed the default secret key value from the configuration docs. Removed the default secret key value from the configuration docs.
* SECRET_KEY Rotation Additional documentation for SECRET_KEY rotation and SECRET_KEY setting up. * Bumped the helm chart version to 0.5.11 Bumped the helm chart version for the new changes. * Removed the default secret key value from the configuration docs. Removed the default secret key value from the configuration docs.
* SECRET_KEY Rotation Additional documentation for SECRET_KEY rotation and SECRET_KEY setting up. * Bumped the helm chart version to 0.5.11 Bumped the helm chart version for the new changes. * Removed the default secret key value from the configuration docs. Removed the default secret key value from the configuration docs.
Additional documentation for SECRET_KEY rotation and SECRET_KEY setting up.
SUMMARY
Currently the SECRET_KEY rotation and SECRET_KEY setting up is missing in the documentation. So added the steps for covering the same.