chore: Make font-weights themable, fix font faces #19236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19236 +/- ##
==========================================
- Coverage 66.55% 66.54% -0.01%
==========================================
Files 1646 1645 -1
Lines 63617 63713 +96
Branches 6471 6503 +32
==========================================
+ Hits 42339 42398 +59
- Misses 19600 19632 +32
- Partials 1678 1683 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@kgabryje Ephemeral environment spinning up at http://34.213.199.151:8080. Credentials are |
|
@jinghua-qa Can you please help us test this one? |
superset-frontend/packages/superset-ui-core/src/chart/components/NoResultsComponent.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-core/test/chart/components/SuperChart.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.js
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts
Outdated
Show resolved
Hide resolved
michael-s-molina
approved these changes
Mar 21, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
michael-hoffman-26
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Mar 23, 2022
* fix(fonts): Import all necessary font packages * Make html tags themable * Set bold font weight to 600, add medium font weight to theme * Replace hard coded font weights with theme variables * Change some font weight light elements to normal * Fix tests * Fix bug in pivot table * Address code review comments
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
* fix(fonts): Import all necessary font packages * Make html tags themable * Set bold font weight to 600, add medium font weight to theme * Replace hard coded font weights with theme variables * Change some font weight light elements to normal * Fix tests * Fix bug in pivot table * Address code review comments
9 tasks
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
src/assets/stylesheets/less/fonts.less, in fact only the fonts with normal font weight were available. That means that font weights other than 400 simply didn't work - weights from 200 to 500 were rendered as 400, bold font weights were extrapolated by the browser. This PR fixes that issue by explicitely importing font files with weights 200, 400, 500 and 600.<h1-6>,<th>and<strong>all usefont-weight: 700by default. I've overriden them globally to usefont-weight: 600.supersetThemefrom 700 to 600, because of the reasons described above.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
The changes affect the whole product - everything should look as it did before (if you compare side-by-side with current look, there are slight differences in how bold texts look - that's because we didn't actually use Inter font's bold version before).
ADDITIONAL INFORMATION
CC @kasiazjc