Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Logo resizing on page load #19307

Merged
merged 2 commits into from
Mar 22, 2022
Merged

fix: Logo resizing on page load #19307

merged 2 commits into from
Mar 22, 2022

Conversation

geido
Copy link
Member

@geido geido commented Mar 22, 2022

SUMMARY

This PR fixes a glitch with the logo resizing during page load.

BEFORE

DEV.Superset.mp4

AFTER

DEV.Superset.1.mp4

TESTING INSTRUCTIONS

  1. Force reload the page.
  2. The logo should not resize on page load

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as a quick fix. As mentioned, we need to investigate a proper fix and remove added styles from superset.less.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #19307 (acde415) into master (a8a48af) will increase coverage by 0.00%.
The diff coverage is 84.61%.

❗ Current head acde415 differs from pull request most recent head cfb0899. Consider uploading reports for the commit cfb0899 to get more accurate results

@@           Coverage Diff           @@
##           master   #19307   +/-   ##
=======================================
  Coverage   66.62%   66.62%           
=======================================
  Files        1671     1671           
  Lines       64556    64558    +2     
  Branches     6506     6505    -1     
=======================================
+ Hits        43009    43012    +3     
+ Misses      19864    19863    -1     
  Partials     1683     1683           
Flag Coverage Δ
javascript 51.33% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/components/Menu.tsx 60.00% <ø> (ø)
superset/commands/importers/exceptions.py 100.00% <ø> (ø)
superset-frontend/src/components/Select/Select.tsx 86.91% <80.00%> (+0.53%) ⬆️
superset/initialization/__init__.py 90.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a48af...cfb0899. Read the comment docs.

@geido
Copy link
Member Author

geido commented Mar 22, 2022

Refactored to avoid moving all the styles to LESS.

@geido geido merged commit d10a3d8 into apache:master Mar 22, 2022
@rusackas
Copy link
Member

This is a follow-up to #19307 to avoid some layout quirks. I'll give it the 2.0 tag treatment as well, since it's so closely related.

@rusackas rusackas added v2.0 risk:breaking-change Issues or PRs that will introduce breaking changes labels Mar 22, 2022
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
* fix resizing logo

* Refactor
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@alephpt
Copy link

alephpt commented Dec 13, 2023

Is there a fix to this, because I'm having this same problem in 3.0.1?

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.11 risk:breaking-change Issues or PRs that will introduce breaking changes size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants