-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Logo resizing on page load #19307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as a quick fix. As mentioned, we need to investigate a proper fix and remove added styles from superset.less
.
Codecov Report
@@ Coverage Diff @@
## master #19307 +/- ##
=======================================
Coverage 66.62% 66.62%
=======================================
Files 1671 1671
Lines 64556 64558 +2
Branches 6506 6505 -1
=======================================
+ Hits 43009 43012 +3
+ Misses 19864 19863 -1
Partials 1683 1683
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Refactored to avoid moving all the styles to LESS. |
This is a follow-up to #19307 to avoid some layout quirks. I'll give it the 2.0 tag treatment as well, since it's so closely related. |
* fix resizing logo * Refactor
* fix resizing logo * Refactor
Is there a fix to this, because I'm having this same problem in 3.0.1? |
SUMMARY
This PR fixes a glitch with the logo resizing during page load.
BEFORE
DEV.Superset.mp4
AFTER
DEV.Superset.1.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION