-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable edits on external assets #19344
feat: disable edits on external assets #19344
Conversation
82fbdd7
to
8b70d35
Compare
e1cf09a
to
d7568a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #19344 +/- ##
==========================================
+ Coverage 66.65% 66.66% +0.01%
==========================================
Files 1675 1676 +1
Lines 64665 64715 +50
Branches 6503 6510 +7
==========================================
+ Hits 43103 43145 +42
- Misses 19876 19880 +4
- Partials 1686 1690 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* feat: disable edits on external assets * Update tests (cherry picked from commit d304849)
* feat: disable edits on external assets * Update tests
SUMMARY
Disable edits on resources (databases, datasets, charts, dashboards) that are marked as managed externally.
This just disables the UI, not the API.
Depends on #19315.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Database managed externally:
Dataset:
Chart:
Also, must save as new:
Dashboard:
Also, edit is disabled:
TESTING INSTRUCTIONS
To test, import the following dashboard: dashboard_export.zip. All the resources in it have been modified to have
is_managed_externally
set to true.The database, dataset, chart, and dashboard should all be uneditable, similar to the screenshots above.
I also updated the unit tests.
ADDITIONAL INFORMATION