fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode #19362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en running sync queries
Codecov Report
@@ Coverage Diff @@
## master #19362 +/- ##
==========================================
- Coverage 66.64% 66.58% -0.06%
==========================================
Files 1674 1677 +3
Lines 64614 64238 -376
Branches 6502 6538 +36
==========================================
- Hits 43061 42772 -289
+ Misses 19868 19766 -102
- Partials 1685 1700 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
LGTM! |
@codemaster08240328 Please feel free to add a review so the PR gets a checkmark :) |
rusackas
approved these changes
Apr 13, 2022
Gwitchr
added a commit
to Gwitchr/superset
that referenced
this pull request
Apr 29, 2022
…in the history tab on sync mode (apache#19362)" This reverts commit 6d5d03e.
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
May 2, 2022
…in the history tab on sync mode (apache#19362)" (apache#19906) This reverts commit 6d5d03e. (cherry picked from commit 1fa841e)
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
…in the history tab on sync mode (apache#19362)" (apache#19906) This reverts commit 6d5d03e.
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…istory tab on sync mode (apache#19362) * fix(sql lab): display the 'View Results' button in the history tab when running sync queries * pr comment
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…in the history tab on sync mode (apache#19362)" (apache#19906) This reverts commit 6d5d03e.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In order to display the 'View Results' button in the history tab of the SQL Lab, the query must have a
resultsKey.When the query is executed in sync mode, that key was not properly propagated from the API to the FE, thus, the button did not appeared after execution.
The button did appeared once the running polling watching for queries updated, since that fetches fresh results from the api.
This PR forwards that key to make the button show for every successfully executed query.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-03-24.at.17.16.06.mov
After:
Screen.Recording.2022-03-24.at.17.14.22.mov
TESTING INSTRUCTIONS
Ensure that, if the queries are successful, the 'View Results' button always displays.
ADDITIONAL INFORMATION