-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sql lab): replace the output column in the query history table #19370
fix(sql lab): replace the output column in the query history table #19370
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19370 +/- ##
=======================================
Coverage 66.30% 66.30%
=======================================
Files 1681 1681
Lines 64408 64406 -2
Branches 6593 6592 -1
=======================================
- Hits 42704 42703 -1
Misses 20020 20020
+ Partials 1684 1683 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2556d56
to
36e30c1
Compare
36e30c1
to
2263b02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…pache#19370) * fix(sql lab): replace the output column in the query history table * improvements
SUMMARY
The current output column in the Query History table in the SQL Lab currently displays the schema if the query failed.
The resulting UI is a column with "View results" button for successful queries and some seemingly random text if the query failed that lacks the appropriate context.
This PR makes some cosmetic changes that include:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Ensure the results column show the View button for successful queries & nothing for failed ones.
ADDITIONAL INFORMATION