fix: Reset sorting bar issue in Barchart

[codemaster08240328]

SUMMARY

When enabling "sort bars" and disabling again, the order isn't reset to the original order.

It was because when we sort data from props, it made updates in redux store as well.

Solution: deep copy

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

[DEV] Genders by State - 25 March 2022 - Watch Video

AFTER:

[DEV] Genders by State - 25 March 2022 - Watch Video

TESTING INSTRUCTIONS

1. Goto charts page
2. Select Genders by State chart
3. Check sort bars under customize tab.
4. Uncheck sort bars.
5. See how chart is rendered.

ADDITIONAL INFORMATION

• Has associated issue: bar chart: disabling "sort bars" doesn't reset sort order #12650
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19371 (c4e4566) into master (a4c261d) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #19371      +/-   ##
==========================================
- Coverage   66.59%   66.53%   -0.06%     
==========================================
  Files        1670     1672       +2     
  Lines       63888    63954      +66     
  Branches     6510     6519       +9     
==========================================
+ Hits        42544    42552       +8     
- Misses      19655    19711      +56     
- Partials     1689     1691       +2     

Flag	Coverage Δ
javascript	51.25% <0.00%> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js	0.00% <0.00%> (ø)
.../components/Header/HeaderActionsDropdown/index.jsx	67.79% <0.00%> (-3.64%)	⬇️
...frontend/src/dashboard/components/Header/index.jsx	60.92% <0.00%> (-0.46%)	⬇️
superset-frontend/src/preamble.ts	0.00% <0.00%> (ø)
superset-frontend/src/embedded/index.tsx	0.00% <0.00%> (ø)
...rc/dashboard/components/DashboardEmbedControls.tsx	8.16% <0.00%> (ø)
...ontend/src/dashboard/containers/DashboardRoute.tsx	0.00% <0.00%> (ø)
...rontend/src/dashboard/containers/DashboardPage.tsx	5.31% <0.00%> (+0.05%)	⬆️
...rset-frontend/src/hooks/apiResources/dashboards.ts	36.36% <0.00%> (+3.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c261d...c4e4566. Read the comment docs.

[rusackas]

LGTM!