fix(dashboard): make to filter the correct certified or non-certified…

[prosdev0107]

SUMMARY

Non certified dashboards appear on dashboard list when filtering by certified

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
In case of certified filter is Yes

In case of certified filter is No

AFTER:
In case of certified filter is Yes

In case of certified filter is No

TESTING INSTRUCTIONS

How to reproduce the bug

1. Certify some dashboards (This can be done from the dashboard CRUD view > edit > certified fields at the bottom of the modal)
2. Go to the dashboard list
3. Should show only certificated Dashboards when the filter option of certified is Yes.

Generally, You will not reproduce this issue anymore with dashboard CRUD. This issue is happened when the certified_by field value is empty string, not null value.(like following image). and so I had a test after changing this forcely into empty string in some dashboards value and then could catch this issue and fix it.

Or you can see this issue on the following workspace;
https://8bf970d2.us1a.app.preset.io/dashboard/list/?filters=(certified:(label:Yes,value:!t))&pageIndex=0&sortColumn=changed_on_delta_humanized&sortOrder=desc&viewMode=table

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19429 (69fc5d8) into master (ac2c66c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19429   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1686     1686           
  Lines       64589    64589           
  Branches     6635     6635           
=======================================
  Hits        42959    42959           
  Misses      19931    19931           
  Partials     1699     1699           

Flag	Coverage Δ
hive	52.69% <ø> (ø)
mysql	81.95% <ø> (ø)
postgres	82.00% <ø> (ø)
presto	52.54% <ø> (ø)
python	82.43% <ø> (ø)
sqlite	81.76% <ø> (ø)
unit	47.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/dashboards/filters.py	93.67% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2c66c...69fc5d8. Read the comment docs.

[prosdev0107]

@rusackas
Would you like to merge this PR into master?

[rusackas]

LGTM!

[rusackas]

Added a couple of click-to-commit suggestions that should fix the Python linting issues blocking this PR.

[zhaoyongjie]

Thanks for fixing this issue. For the short term, the fix is good. for the long term, I suggest adding todo notation in the codebase. We might set the certified_by to NULL in the Dashboard model when the user deactivates certified so that only keep is null in where clause.

[rusackas]

Thanks for fixing this issue. For the short term, the fix is good. for the long term, I suggest adding todo notation in the codebase. We might set the certified_by to NULL in the Dashboard model when the user deactivates certified so that only keep is null in where clause.

@prosdev0107 do you want to add that TODO as suggested?

[prosdev0107]

@rusackas @zhaoyongjie
According to my local testing result, the certified_by is already keeping only null value when user creates new dashboard or deactivates existing certified on current codebase. So I am wondering if I should add this TODO.

I just added one more condition into where clause for filtering dashboards correctly that was saved before that is keeping only null value when user deactivates certified.

Anyway, I can add TODO as suggested for any unexpected case.