Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove StyledQueryButton.less #19441

Merged
merged 2 commits into from
Apr 4, 2022
Merged

chore: Remove StyledQueryButton.less #19441

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aba8da
Remove StyledQueryButton less
geido Mar 30, 2022
3b76160
Remove unused className
geido Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions superset-frontend/src/SqlLab/components/ScheduleQueryButton/ScheduleQueryButton.less
View file
Open in desktop

This file was deleted.

23 changes: 20 additions & 3 deletions superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import { t, styled } from '@superset-ui/core';
import * as chrono from 'chrono-node';
import ModalTrigger from 'src/components/ModalTrigger';
import { Form, FormItem } from 'src/components/Form';
import './ScheduleQueryButton.less';
import Button from 'src/components/Button';

const appContainer = document.getElementById('app');
Expand Down Expand Up @@ -111,6 +110,24 @@ export const StyledButtonComponent = styled(Button)`
}
`;

const StyledJsonSchema = styled.div`
i.glyphicon {
display: none;
}
.btn-add::after {
content: '+';
}
.array-item-move-up::after {
content: '↑';
}
.array-item-move-down::after {
content: '↓';
}
.array-item-remove::after {
content: '-';
}
`;

const ScheduleQueryButton: FunctionComponent<ScheduleQueryButtonProps> = ({
defaultLabel = t('Undefined'),
sql,
Expand Down Expand Up @@ -175,7 +192,7 @@ const ScheduleQueryButton: FunctionComponent<ScheduleQueryButtonProps> = ({
</StyledRow>
<Row>
<Col xs={24}>
<div className="json-schema">
<StyledJsonSchema className="json-schema">
geido marked this conversation as resolved.
Show resolved Hide resolved
<SchemaForm
schema={getJSONSchema()}
uiSchema={getUISchema}
Expand All @@ -190,7 +207,7 @@ const ScheduleQueryButton: FunctionComponent<ScheduleQueryButtonProps> = ({
Submit
</Button>
</SchemaForm>
</div>
</StyledJsonSchema>
</Col>
</Row>
{scheduleQueryWarning && (
Expand Down