Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql lab): when editing a saved query, the status is lost when switching tabs #19448

Merged

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

When opening a saved query, the SQL Lab does not retain the "saved" status after switching to another query and switching back.
So, the edited query cannot be updated, nor can it's perma link be retrieved.

This PR ensures that, when opening any saved query, the tab retains the save status even when switching to another tab.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-03-30.at.17.14.37.mov

After:

Screen.Recording.2022-03-30.at.17.12.16.mov

TESTING INSTRUCTIONS

  1. Go to Saved Queries
  2. Click on a saved query, open it in sql lab
  3. Create a new tab, then go back to the original tab.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #19448 (fb50b00) into master (e061955) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19448   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1690     1690           
  Lines       64614    64614           
  Branches     6655     6655           
=======================================
  Hits        42978    42978           
  Misses      19936    19936           
  Partials     1700     1700           
Flag Coverage Δ
javascript 51.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 60.39% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e061955...fb50b00. Read the comment docs.

@diegomedina248 diegomedina248 force-pushed the fix/sql-lab-saved-query-edit-issue branch 3 times, most recently from 7485029 to 9bbfca4 Compare April 11, 2022 13:49
@diegomedina248 diegomedina248 force-pushed the fix/sql-lab-saved-query-edit-issue branch from 9bbfca4 to fb50b00 Compare April 19, 2022 20:41
Copy link
Contributor

@codemaster08240328 codemaster08240328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@rusackas rusackas merged commit 800ced5 into apache:master Apr 22, 2022
villebro pushed a commit that referenced this pull request Apr 25, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 Preset-Patch size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants