-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sql lab): when editing a saved query, the status is lost when switching tabs #19448
fix(sql lab): when editing a saved query, the status is lost when switching tabs #19448
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19448 +/- ##
=======================================
Coverage 66.51% 66.51%
=======================================
Files 1690 1690
Lines 64614 64614
Branches 6655 6655
=======================================
Hits 42978 42978
Misses 19936 19936
Partials 1700 1700
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
7485029
to
9bbfca4
Compare
9bbfca4
to
fb50b00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
SUMMARY
When opening a saved query, the SQL Lab does not retain the "saved" status after switching to another query and switching back.
So, the edited query cannot be updated, nor can it's perma link be retrieved.
This PR ensures that, when opening any saved query, the tab retains the save status even when switching to another tab.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-03-30.at.17.14.37.mov
After:
Screen.Recording.2022-03-30.at.17.12.16.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION