-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flaky test for charts changed on #19483
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19483 +/- ##
==========================================
- Coverage 66.58% 66.53% -0.06%
==========================================
Files 1676 1676
Lines 64176 64176
Branches 6525 6525
==========================================
- Hits 42732 42697 -35
- Misses 19745 19780 +35
Partials 1699 1699
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8f9df07
to
02f202e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's really challenging to get these timedeltas aligned, I wonder if we should just do assert data["result"][0]["changed_on_delta_humanized"] in ("now", "a second ago")
? Not elegant, I know, but should work with very high confidence..
Unfortunately, |
02f202e
to
30d4a5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit a2e921b)
(cherry picked from commit a2e921b)
SUMMARY
There is a flaky test for charts changed on the case. This PR changes the assertion to ("now", "a second ago")
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION