fix: Dynamic form to connect to Snowflake DB is not displaying authentication errors #19491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemaster08240328
suggested changes
Apr 1, 2022
| ...obj, | ||
| error_type, | ||
| description: | ||
| message || extra?.issue_codes?.[0]?.message, |
There was a problem hiding this comment.
we don't need conditional sign ? here, because you already checked it in line# 751.
Just use extra.issue_codes[0].message
Btw, are you sure that issue_code has always message?
There was a problem hiding this comment.
nop, and in that case it will fallback to show the json (like the others)
Codecov Report
@@ Coverage Diff @@
## master #19491 +/- ##
==========================================
- Coverage 66.59% 66.57% -0.02%
==========================================
Files 1676 1677 +1
Lines 64211 64241 +30
Branches 6537 6540 +3
==========================================
+ Hits 42762 42770 +8
- Misses 19750 19770 +20
- Partials 1699 1701 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 5, 2022
…tication errors (apache#19491) * fix: Dynamic form to connect to Snowflake DB is not displaying authentication errors * pr comments (cherry picked from commit 634693b)
|
🏷️ preset:2022.13 |
9 tasks
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…tication errors (apache#19491) * fix: Dynamic form to connect to Snowflake DB is not displaying authentication errors * pr comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There are two ways to create a connection with a Snowflake DB:
Using the dynamic form.
Using a SQLAlchemy URI string.
However, the dynamic form is not displaying authentication errors to the user, in case the authentication fails.
This PR adds additional code to trap that error and display it to the user.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-04-01.at.13.07.07.mov
After:
new.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION