-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enhance ReactChord style with theme vars #19517
Conversation
superset-frontend/plugins/legacy-plugin-chart-chord/src/ReactChord.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a non-blocking comment.
…hord.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #19517 +/- ##
==========================================
- Coverage 66.59% 66.59% -0.01%
==========================================
Files 1678 1682 +4
Lines 64242 64294 +52
Branches 6539 6554 +15
==========================================
+ Hits 42784 42817 +33
- Misses 19763 19776 +13
- Partials 1695 1701 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Enhance style with theme vars * Update superset-frontend/plugins/legacy-plugin-chart-chord/src/ReactChord.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
SUMMARY
It enhances the ReactChord component style with theme vars.
BEFORE
DEV.Cross.Channel.Relationship.1.mp4
AFTER
DEV.Cross.Channel.Relationship.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
q