fix: add back view for report reload error #19522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
approved these changes
Apr 4, 2022
Codecov Report
@@ Coverage Diff @@
## master #19522 +/- ##
==========================================
- Coverage 66.59% 66.43% -0.17%
==========================================
Files 1678 1678
Lines 64242 64246 +4
Branches 6539 6539
==========================================
- Hits 42784 42680 -104
- Misses 19763 19871 +108
Partials 1695 1695
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 5, 2022
* fix: add back view for report reload error * remove print * run black (cherry picked from commit 79abd23)
|
🏷️ preset:2022.13 |
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* fix: add back view for report reload error * remove print * run black
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pr fixes an issue when the user reloads the reports page and it returns an 404. Issue was because the reports view was mistakenly removed during the 2.0 code migration.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
Screen.Recording.2022-04-04.at.1.37.01.PM.mov
after
Screen.Recording.2022-04-04.at.2.53.29.PM.mov
TESTING INSTRUCTIONS
Go to reports list view and reload the page. Page should not error in 404.
ADDITIONAL INFORMATION