Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back view for report reload error #19522

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Apr 4, 2022

SUMMARY

This pr fixes an issue when the user reloads the reports page and it returns an 404. Issue was because the reports view was mistakenly removed during the 2.0 code migration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2022-04-04.at.1.37.01.PM.mov

after

Screen.Recording.2022-04-04.at.2.53.29.PM.mov

TESTING INSTRUCTIONS

Go to reports list view and reload the page. Page should not error in 404.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #19522 (95f4d4c) into master (c2fae82) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19522      +/-   ##
==========================================
- Coverage   66.59%   66.43%   -0.17%     
==========================================
  Files        1678     1678              
  Lines       64242    64246       +4     
  Branches     6539     6539              
==========================================
- Hits        42784    42680     -104     
- Misses      19763    19871     +108     
  Partials     1695     1695              
Flag Coverage Δ
hive ?
mysql 81.90% <100.00%> (+<0.01%) ⬆️
postgres 81.95% <100.00%> (+<0.01%) ⬆️
presto ?
python 82.05% <100.00%> (-0.34%) ⬇️
sqlite 81.72% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/initialization/__init__.py 91.31% <100.00%> (-0.32%) ⬇️
superset/views/alerts.py 80.00% <100.00%> (+2.22%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.00% <0.00%> (-15.77%) ⬇️
superset/db_engine_specs/presto.py 83.60% <0.00%> (-5.40%) ⬇️
superset/connectors/sqla/models.py 88.10% <0.00%> (-1.21%) ⬇️
superset/db_engine_specs/base.py 88.00% <0.00%> (-0.34%) ⬇️
superset/models/core.py 88.80% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.71% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fae82...95f4d4c. Read the comment docs.

@pkdotson pkdotson merged commit 79abd23 into apache:master Apr 4, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 5, 2022
* fix: add back view for report reload error

* remove print

* run black

(cherry picked from commit 79abd23)
@sadpandajoe
Copy link
Member

🏷️ preset:2022.13

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* fix: add back view for report reload error

* remove print

* run black
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.13 preset-io size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants