Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes hard-coded opacity and spacing from the BigNumber plugin #19536

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Removes hard-coded opacity and spacing from the BigNumber plugin.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-04-05 at 3 09 40 PM

Screen Shot 2022-04-05 at 3 10 56 PM

TESTING INSTRUCTIONS

Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

border-radius: 3px;

&.no-trendline .subheader-line {
padding-bottom: 0.3em;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep em values because the font is scalling.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #19536 (18ca59d) into master (1eef923) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #19536      +/-   ##
==========================================
- Coverage   66.60%   66.59%   -0.01%     
==========================================
  Files        1678     1682       +4     
  Lines       64246    64292      +46     
  Branches     6539     6554      +15     
==========================================
+ Hits        42788    42817      +29     
- Misses      19763    19774      +11     
- Partials     1695     1701       +6     
Flag Coverage Δ
javascript 51.36% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx 0.00% <0.00%> (ø)
...rc/explore/components/ExploreChartHeader/index.jsx 41.07% <0.00%> (-8.93%) ⬇️
.../explore/components/ExploreViewContainer/index.jsx 54.39% <0.00%> (-2.60%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (ø)
superset-frontend/src/profile/App.tsx 0.00% <0.00%> (ø)
...uperset-frontend/src/components/FaveStar/index.tsx 100.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-treemap/src/Treemap.js 0.00% <0.00%> (ø)
...src/components/FilterableTable/FilterableTable.tsx 71.42% <0.00%> (ø)
...ugins/legacy-plugin-chart-sunburst/src/Sunburst.js 0.00% <0.00%> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eef923...18ca59d. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 356a038 into apache:master Apr 6, 2022
@michael-s-molina michael-s-molina added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants