-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Removes the CSS files from the Parallel Coordinates plugin #19539
refactor: Removes the CSS files from the Parallel Coordinates plugin #19539
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19539 +/- ##
==========================================
+ Coverage 66.60% 66.65% +0.05%
==========================================
Files 1678 1680 +2
Lines 64246 64253 +7
Branches 6539 6561 +22
==========================================
+ Hits 42788 42826 +38
+ Misses 19763 19725 -38
- Partials 1695 1702 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
.parcoords .header { | ||
clear: left; | ||
font-size: ${theme.typography.sizes.s}px; | ||
line-height: 18px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-s-molina do you think it makes sense to use grid units for line heights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have a specific category for line-heights in our theme. We just need to figure out which ones should be available and include them with the other theme suggestions for the design team. Let's tackle line-heights in a specific task force.
…pache#19539) * refactor: Removes the CSS files from the Parallel Coordinates plugin * Adds test * Fixes indentation
SUMMARY
This PR removes the CSS files from the Parallel Coordinates plugin using Emotion. It also adjusts the styles to match theme configuration and existing components.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.
ADDITIONAL INFORMATION