fix(dataset): handle missing python_type gracefully

[villebro]

SUMMARY

In the new Dataset model, we check if a column is temporal by checking the python_type of all columns. However, the property isn't guaranteed to be implemented: https://github.com/sqlalchemy/sqlalchemy/blob/7935b76d9e5b5fd4e64b2c6c3473737186acf2db/lib/sqlalchemy/sql/type_api.py#L618-L635 . Therefore, if calling it raises NotImplementedError, we assume the column is not temporal.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: closes Error while saving Virtual data set using explore 1.5.0rc1 #19546
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[zhaoyongjie]

LGTM!

[codecov]

Codecov Report

Merging #19553 (1508c66) into master (aa419b8) will decrease coverage by 12.91%.
The diff coverage is 42.85%.

❗ Current head 1508c66 differs from pull request most recent head b95fb1a. Consider uploading reports for the commit b95fb1a to get more accurate results

@@             Coverage Diff             @@
##           master   #19553       +/-   ##
===========================================
- Coverage   66.65%   53.74%   -12.92%     
===========================================
  Files        1680     1680               
  Lines       64280    64286        +6     
  Branches     6564     6564               
===========================================
- Hits        42849    34550     -8299     
- Misses      19729    28034     +8305     
  Partials     1702     1702               

Flag	Coverage Δ
hive	?
mysql	?
postgres	?
presto	52.54% <42.85%> (-0.01%)	⬇️
python	56.10% <42.85%> (-26.29%)	⬇️
sqlite	?
unit	47.21% <42.85%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/connectors/sqla/utils.py	76.53% <42.85%> (-18.04%)	⬇️
superset/utils/dashboard_import_export.py	0.00% <0.00%> (-100.00%)	⬇️
superset/key_value/commands/upsert.py	0.00% <0.00%> (-89.59%)	⬇️
superset/key_value/commands/update.py	0.00% <0.00%> (-89.37%)	⬇️
superset/key_value/commands/delete.py	0.00% <0.00%> (-85.30%)	⬇️
superset/db_engines/hive.py	0.00% <0.00%> (-85.19%)	⬇️
superset/key_value/commands/delete_expired.py	0.00% <0.00%> (-80.77%)	⬇️
superset/dashboards/commands/importers/v0.py	14.79% <0.00%> (-75.15%)	⬇️
superset/datasets/commands/importers/v0.py	24.82% <0.00%> (-68.80%)	⬇️
superset/databases/commands/test_connection.py	31.42% <0.00%> (-68.58%)	⬇️
... and 266 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa419b8...b95fb1a. Read the comment docs.

[sadpandajoe]

🏷️ preset:2022.13