refactor: Removes the CSS files from the Horizon plugin #19562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19562 +/- ##
==========================================
+ Coverage 66.65% 66.68% +0.02%
==========================================
Files 1680 1681 +1
Lines 64292 64303 +11
Branches 6564 6565 +1
==========================================
+ Hits 42854 42878 +24
+ Misses 19736 19730 -6
+ Partials 1702 1695 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
geido
approved these changes
Apr 7, 2022
geido
reviewed
Apr 7, 2022
superset-frontend/plugins/legacy-plugin-chart-horizon/src/HorizonChart.jsx
Outdated
Show resolved
Hide resolved
michael-s-molina
force-pushed
the
horizon-to-emotion
branch
from
5da279e
to
9f9b9f4
Compare
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* refactor: Removes the CSS files from the Horizon plugin * Removes the CSS file * Uses font-size from the theme
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR removes the CSS files from the Horizon plugin using Emotion. It also adjusts the styles to match theme configuration and existing components.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.
ADDITIONAL INFORMATION