chore: cleanup as unknown conversion #19587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
commented
Apr 7, 2022
| @@ -285,7 +285,8 @@ describe('buildQueryObject', () => { | |||
| datasource: '5__table', | |||
| granularity_sqla: 'ds', | |||
| viz_type: 'table', | |||
| url_params: null as unknown as undefined, | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
ignore is used for the test case.
There was a problem hiding this comment.
I believe // @ts-expect-error is the correct syntax for testing with incorrect types
zhaoyongjie
commented
Apr 7, 2022
| @@ -226,7 +226,7 @@ function QuerySearch({ actions, displayLimit }: QuerySearchProps) { | |||
| value: xt, | |||
| label: xt, | |||
| }))} | |||
| value={from as unknown as undefined} | |||
| value={{ value: from, label: from }} | |||
There was a problem hiding this comment.
bycatch: use object fill in Select value
zhaoyongjie
commented
Apr 7, 2022
| @@ -235,7 +235,7 @@ function QuerySearch({ actions, displayLimit }: QuerySearchProps) { | |||
| name="select-to" | |||
| placeholder={t('[To]-')} | |||
| options={TIME_OPTIONS.map(xt => ({ value: xt, label: xt }))} | |||
| value={to as unknown as undefined} | |||
| value={{ value: to, label: to }} | |||
zhaoyongjie
commented
Apr 7, 2022
| @@ -247,7 +247,7 @@ function QuerySearch({ actions, displayLimit }: QuerySearchProps) { | |||
| value: s, | |||
| label: s, | |||
| }))} | |||
| value={status as unknown as undefined} | |||
| value={{ value: status, label: status }} | |||
zhaoyongjie
commented
Apr 7, 2022
| filterSets: {}, | ||
| filters: { |
zhaoyongjie
commented
Apr 7, 2022
Comment on lines
-374
to
+378
| const engineParamsCatalog = Object.keys( | ||
| const engineParamsCatalog = Object.entries( | ||
| extra_json?.engine_params?.catalog || {}, | ||
| ).map(e => ({ | ||
| name: e, | ||
| value: extra_json?.engine_params?.catalog[e], | ||
| ).map(([key, value]) => ({ | ||
| name: key, | ||
| value, |
There was a problem hiding this comment.
same logical substitution
zhaoyongjie
commented
Apr 7, 2022
| catalog: Record<any, any> | string; | ||
| catalog?: Record<any, any> | string; |
There was a problem hiding this comment.
catalog is an optional field in engine params
zhaoyongjie
force-pushed
the
cleanup_asunknown
branch
from
f78a03b
to
001b975
Compare
Codecov Report
@@ Coverage Diff @@
## master #19587 +/- ##
==========================================
+ Coverage 66.65% 66.68% +0.02%
==========================================
Files 1680 1681 +1
Lines 64292 64309 +17
Branches 6564 6565 +1
==========================================
+ Hits 42855 42885 +30
+ Misses 19735 19731 -4
+ Partials 1702 1693 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zhaoyongjie
commented
Apr 8, 2022
Comment on lines
77
to
89
| export function addAlpha(color: string, opacity: number): string { | ||
| // coerce values so ti is between 0 and 1. | ||
| const rounded = Math.round(Math.min(Math.max(opacity || 1, 0), 1) * 255); | ||
| return color + rounded.toString(16).toUpperCase(); | ||
| // opacity value should be between 0 and 1. | ||
| if (opacity > 1 || opacity < 0) { | ||
| throw new Error( | ||
| `The alpha channel should between 0 and 1, but got: ${opacity}`, | ||
| ); | ||
| } | ||
| // the alpha value is between 00 - FF | ||
| const alpha = `0${Math.round(opacity * 255) | ||
| .toString(16) | ||
| .toUpperCase()}`.slice(-2); | ||
|
|
||
| return `${color}${alpha}`; |
There was a problem hiding this comment.
bycatch: fix codes coverage.
villebro
approved these changes
Apr 8, 2022
| @@ -285,7 +285,8 @@ describe('buildQueryObject', () => { | |||
| datasource: '5__table', | |||
| granularity_sqla: 'ds', | |||
| viz_type: 'table', | |||
| url_params: null as unknown as undefined, | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
I believe // @ts-expect-error is the correct syntax for testing with incorrect types
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Clean up as unknown after monorepo
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Pass all CI
ADDITIONAL INFORMATION