-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove wrong usage of font-size in ExploreViewContainer #19614
chore: Remove wrong usage of font-size in ExploreViewContainer #19614
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19614 +/- ##
==========================================
- Coverage 66.63% 66.44% -0.19%
==========================================
Files 1680 1681 +1
Lines 64292 64397 +105
Branches 6564 6593 +29
==========================================
- Hits 42839 42787 -52
- Misses 19751 19926 +175
+ Partials 1702 1684 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I'm not sure if we can make this change without changing the other headers together. The Dataset header looked disproportional when testing the application. It looks like those commit all or roll back all kinds of PR. What do you think @kasiazjc? |
Just had a discussion with Kasia. All of those headers should be 12px and I am going to apply the changes to this PR |
@michael-s-molina here is how it looks now |
Waaaaaay better! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e#19614) * Remove hacky usage of font-size * Update font
SUMMARY
It removes an unnecessary font-size and fixes a className to match the right layout as detailed in #19099
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION