Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting CLI changes in #1713 #1964

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jan 12, 2017

These changes were introduced to prevent forking of the SQLAlchemy objects when Gunicorn is started, which had an issue when running a pex in Kubernetes.

We've found a different way to package the pex to prevent this issue.

@bkyryliuk @yolken

@bkyryliuk
Copy link
Member

LGTM

@mistercrunch mistercrunch merged commit 99b84d2 into apache:master Jan 13, 2017
@mistercrunch mistercrunch deleted the revert_cli_changes branch January 13, 2017 20:37
SalehHindi pushed a commit to SalehHindi/superset that referenced this pull request Jun 9, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.15.3 labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.15.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants