Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow_browser_login in import/export API #19656

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Apr 12, 2022

SUMMARY

Add missing allow_browser_login to the new (introduced in #19220) import/export API, otherwise users can't interact with it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Log in and visit https://example.org/api/v1/assets/export/, a ZIP should be downloaded.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #19656 (4b067fe) into master (9554135) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19656      +/-   ##
==========================================
- Coverage   66.47%   66.31%   -0.17%     
==========================================
  Files        1681     1681              
  Lines       64467    64468       +1     
  Branches     6607     6607              
==========================================
- Hits        42856    42750     -106     
- Misses      19917    20024     +107     
  Partials     1694     1694              
Flag Coverage Δ
hive ?
mysql 81.90% <100.00%> (+<0.01%) ⬆️
postgres 81.95% <100.00%> (+<0.01%) ⬆️
presto ?
python 82.05% <100.00%> (-0.34%) ⬇️
sqlite 81.72% <100.00%> (+<0.01%) ⬆️
unit 47.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/importexport/api.py 100.00% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.11% <0.00%> (-15.71%) ⬇️
superset/db_engine_specs/presto.py 83.64% <0.00%> (-5.39%) ⬇️
superset/connectors/sqla/models.py 88.24% <0.00%> (-1.22%) ⬇️
superset/db_engine_specs/base.py 88.01% <0.00%> (-0.34%) ⬇️
superset/models/core.py 88.83% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.71% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9554135...4b067fe. Read the comment docs.

@betodealmeida betodealmeida merged commit 5c63df5 into apache:master Apr 12, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants