-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update ShortKey for stop query running in SqlLab editor #19692
feat: Update ShortKey for stop query running in SqlLab editor #19692
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19692 +/- ##
=======================================
Coverage 66.54% 66.54%
=======================================
Files 1692 1692
Lines 64775 64811 +36
Branches 6661 6663 +2
=======================================
+ Hits 43103 43131 +28
- Misses 19972 19978 +6
- Partials 1700 1702 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -114,7 +117,9 @@ const RunQueryActionButton = ({ | |||
tooltip={ | |||
(!isDisabled && | |||
(shouldShowStopBtn | |||
? t('Stop running (Ctrl + x)') | |||
? userOS === 'MacOS' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could move this to a memo, or even a plain function outside of the component called getStopButtonTooltipText
or something.. Seems too much inline ifs for my liking here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Willing to take a look at externalizing this, and squeeze it into this PR, @codemaster08240328?
superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx
Outdated
Show resolved
Hide resolved
Tests for this would be appreciated as a follow-up PR. |
…#19692) * feat: Update shortkey for stop query running in sqllab editor * resolve comment * fix invalid import useMemo
…#19692) * feat: Update shortkey for stop query running in sqllab editor * resolve comment * fix invalid import useMemo
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Stop query
buttonADDITIONAL INFORMATION