Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db & connection): make to show/hide the password when only creating db connection #19694

Merged
merged 4 commits into from
Apr 26, 2022
Merged

fix(db & connection): make to show/hide the password when only creating db connection #19694

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a35066
fix(db & connection): make to show/hide the password when only creati…
prosdev0107 Apr 13, 2022
15672a9
fix(db & connection): make to rebase master
prosdev0107 Apr 15, 2022
3028392
fix(db & connection): make to rebase master
prosdev0107 Apr 25, 2022
4b7de08
fix(db & connection): make to fix unit test of Database Modal
prosdev0107 Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
* under the License.
*/
import React from 'react';
import { Input } from 'antd';
import { Input, Tooltip } from 'antd';
AAfghahi marked this conversation as resolved.
Show resolved Hide resolved
import { EyeInvisibleOutlined, EyeOutlined } from '@ant-design/icons';
import { styled, css, SupersetTheme } from '@superset-ui/core';
import InfoTooltip from 'src/components/InfoTooltip';
import errorIcon from 'src/assets/images/icons/error.svg';
Expand All @@ -43,6 +44,10 @@ const StyledInput = styled(Input)`
margin: ${({ theme }) => `${theme.gridUnit}px 0 ${theme.gridUnit * 2}px`};
`;

const StyledInputPassword = styled(Input.Password)`
margin: ${({ theme }) => `${theme.gridUnit}px 0 ${theme.gridUnit * 2}px`};
`;

const alertIconStyles = (theme: SupersetTheme, hasError: boolean) => css`
.ant-form-item-children-icon {
display: none;
Expand Down Expand Up @@ -114,7 +119,25 @@ const LabeledErrorBoundInput = ({
help={errorMessage || helpText}
hasFeedback={!!errorMessage}
>
<StyledInput {...props} {...validationMethods} />
{props.name === 'password' ? (
<StyledInputPassword
{...props}
{...validationMethods}
iconRender={visible =>
visible ? (
<Tooltip title="Hide password.">
<EyeInvisibleOutlined />
</Tooltip>
) : (
<Tooltip title="Show password.">
<EyeOutlined />
</Tooltip>
)
}
/>
) : (
<StyledInput {...props} {...validationMethods} />
)}
</FormItem>
</StyledFormGroup>
);
Expand Down