Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update alerts-reports #19697

Closed
wants to merge 1 commit into from
Closed

Conversation

cemremengu
Copy link
Contributor

SUMMARY

CELERYBEAT_SCHEDULE -> beat_schedule

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CELERYBEAT_SCHEDULE  -> beat_schedule
@rusackas
Copy link
Member

Eek! This slipped through the cracks, but it looks like the gist of it was merged by @sfirke in #20872

Closing this one, but if either @cemremengu or @sfirke want to take a look, it seems the cache.py file still has some remaining comments that are using CELERYBEAT_SCHEDULE - should we clean those up too, I assume?

@rusackas rusackas closed this Jan 25, 2023
@cemremengu cemremengu deleted the patch-2 branch January 26, 2023 06:40
@cemremengu
Copy link
Contributor Author

@rusackas I agree, sent a PR #22865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants