Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enabling source maps full time #19710

Merged
merged 1 commit into from
Apr 14, 2022
Merged

feat: Enabling source maps full time #19710

merged 1 commit into from
Apr 14, 2022

Conversation

rusackas
Copy link
Member

SUMMARY

Since a lot of folks are debugging on prod builds, source maps would sure be helpful! Also, they don't get loaded by browsers unless the dev tools are open, so there should be no real performance hit. This PR turns on source maps for styles and JS.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Build an ephemeral environment and attempt to debug styles/JS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #19710 (488ac2a) into master (32a9265) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19710   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files        1684     1684           
  Lines       64570    64570           
  Branches     6630     6630           
=======================================
  Hits        42941    42941           
  Misses      19931    19931           
  Partials     1698     1698           
Flag Coverage Δ
hive 52.69% <ø> (ø)
javascript 51.14% <ø> (ø)
mysql 81.94% <ø> (ø)
postgres 81.99% <ø> (ø)
presto 52.54% <ø> (ø)
python 82.43% <ø> (ø)
sqlite 81.76% <ø> (ø)
unit 47.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a9265...488ac2a. Read the comment docs.

@ktmud ktmud merged commit 34008f7 into master Apr 14, 2022
@rusackas rusackas deleted the hooray-source-maps branch April 14, 2022 16:38
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants