-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 10/15/30 min grain to Pinot #19724
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19724 +/- ##
==========================================
- Coverage 66.51% 66.32% -0.19%
==========================================
Files 1686 1686
Lines 64589 64589
Branches 6635 6635
==========================================
- Hits 42959 42838 -121
- Misses 19931 20052 +121
Partials 1699 1699
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @hughhhh was going to try to test these time grains with a Pinot db, but this lgtm.
* add new grains to pinot * update test
SUMMARY
Adding new time grains to Pinot
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION