Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-chart-echarts): [feature parity] annotation line chart color does not work #19758

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR fixes the problem that the annotation line chart color of time-series echart does not work.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-04-18.10.46.47.mov

after

2022-04-18.10.45.16.mov

TESTING INSTRUCTIONS

Follow up this issue #19299.
See the result.

ADDITIONAL INFORMATION

  • Has associated issue: Annotation line chart color cannot be changed  #19299
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #19758 (3b4115a) into master (57157c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19758   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1687     1687           
  Lines       64620    64621    +1     
  Branches     6646     6647    +1     
=======================================
+ Hits        42980    42981    +1     
  Misses      19940    19940           
  Partials     1700     1700           
Flag Coverage Δ
javascript 51.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 57.89% <ø> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 51.63% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57157c8...3b4115a. Read the comment docs.

@satiukov-ed
Copy link

Will it be possible to change color of markers? I think this may be the case because there are situations when you need to add an annotation that consists of one point only.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this! And bonus points for remembering Mixed Timeseries (the one everyone always forgets 😆 )

@villebro villebro merged commit 1156297 into apache:master Apr 28, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants