Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SIP-68): handle empty table name during migration #19793

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Apr 20, 2022

SUMMARY

This should fix #19421 (comment)

Reproduced and tested locally by manually setting a local physical SqlaTable to have empty table name:

update tables set table_name = '' where id = 1;

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@ktmud ktmud requested a review from a team as a code owner April 20, 2022 17:20
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #19793 (639ab5c) into master (5e468f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19793   +/-   ##
=======================================
  Coverage   66.54%   66.54%           
=======================================
  Files        1692     1692           
  Lines       64775    64775           
  Branches     6661     6661           
=======================================
  Hits        43103    43103           
  Misses      19972    19972           
  Partials     1700     1700           
Flag Coverage Δ
hive 52.85% <ø> (ø)
mysql 81.90% <ø> (ø)
postgres 81.95% <ø> (ø)
presto 52.70% <ø> (ø)
python 82.37% <ø> (ø)
sqlite 81.71% <ø> (ø)
unit 47.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e468f7...639ab5c. Read the comment docs.

@ktmud ktmud merged commit fa68036 into apache:master Apr 21, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
@john-bodley john-bodley deleted the new-dataset-model-migration-fix branch June 8, 2022 05:32
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants