WIP: Registry to datasourcedao #19811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
reviewed
May 3, 2022
| @@ -19,7 +19,6 @@ | |||
| from werkzeug.local import LocalProxy | |||
|
|
|||
| from superset.app import create_app | |||
| from superset.connectors.connector_registry import ConnectorRegistry | |||
| from superset.extensions import ( | |||
There was a problem hiding this comment.
you're going to want to add the datasourceDao in here so that you can reference it later like from superset import DatasourceDAO
eschutho
reviewed
May 3, 2022
| @@ -21,25 +21,25 @@ | |||
|
|
|||
| from superset.common.chart_data import ChartDataResultType | |||
| from superset.common.query_object import QueryObject | |||
| from superset.dao.datasource import DatasourceDAO | |||
There was a problem hiding this comment.
use from superset import DatasourceDAO here like ConnectorRegistry was below in the type_checking
eschutho
reviewed
May 3, 2022
| @@ -21,25 +21,25 @@ | |||
|
|
|||
| from superset.common.chart_data import ChartDataResultType | |||
| from superset.common.query_object import QueryObject | |||
| from superset.dao.datasource import DatasourceDAO | |||
| from superset.utils.core import apply_max_row_limit, DatasourceDict | |||
| from superset.utils.date_parser import get_since_until | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from sqlalchemy.orm import sessionmaker | |||
|
|
|||
eschutho
reviewed
May 3, 2022
| from superset.commands.base import BaseCommand | ||
| from superset.connectors.sqla.models import SqlaTable, SqlMetric, TableColumn | ||
| from superset.dao.datasource import DatasourceDAO |
There was a problem hiding this comment.
use from superset import DatasourceDAO
eschutho
reviewed
May 3, 2022
superset/models/dashboard.py
Outdated
| from superset.common.request_contexed_based import is_user_admin | ||
| from superset.connectors.base.models import BaseDatasource | ||
| from superset.connectors.druid.models import DruidColumn, DruidMetric | ||
| from superset.connectors.sqla.models import SqlMetric, TableColumn | ||
| from superset.dao.datasource import DatasourceDAO |
There was a problem hiding this comment.
use from superset import DatasourceDAO
eschutho
reviewed
May 3, 2022
| @@ -39,7 +39,8 @@ | |||
| from sqlalchemy.orm import relationship | |||
| from sqlalchemy.orm.mapper import Mapper | |||
|
|
|||
| from superset import ConnectorRegistry, db, is_feature_enabled, security_manager | |||
| from superset import db, is_feature_enabled, security_manager | |||
| from superset.dao.datasource import DatasourceDAO | |||
There was a problem hiding this comment.
use from superset import DatasourceDAO
pkdotson
force-pushed
the
registry-to-datasourcedao
branch
from
3786e29 to
e5c1479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION