Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing f prefix on f-strings #19826

Merged

Conversation

code-review-doctor
Copy link
Contributor

Fixes #19825

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, thanks for the automated fix!

@etr2460 etr2460 changed the title Missing f prefix on f-strings fix fix: Missing f prefix on f-strings Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #19826 (eb2a877) into master (800ced5) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

❗ Current head eb2a877 differs from pull request most recent head 6f7f8f8. Consider uploading reports for the commit 6f7f8f8 to get more accurate results

@@            Coverage Diff             @@
##           master   #19826      +/-   ##
==========================================
- Coverage   66.55%   66.38%   -0.17%     
==========================================
  Files        1692     1692              
  Lines       64802    64802              
  Branches     6657     6657              
==========================================
- Hits        43129    43021     -108     
- Misses      19973    20081     +108     
  Partials     1700     1700              
Flag Coverage Δ
hive ?
mysql 81.90% <0.00%> (ø)
postgres 81.94% <0.00%> (ø)
presto ?
python 82.03% <0.00%> (-0.34%) ⬇️
sqlite 81.71% <0.00%> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 83.36% <0.00%> (-5.34%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.11% <0.00%> (-15.71%) ⬇️
superset/connectors/sqla/models.py 88.84% <0.00%> (-1.20%) ⬇️
superset/initialization/__init__.py 91.37% <0.00%> (-0.35%) ⬇️
superset/db_engine_specs/base.py 88.01% <0.00%> (-0.34%) ⬇️
superset/models/core.py 89.09% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.71% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800ced5...6f7f8f8. Read the comment docs.

@etr2460 etr2460 merged commit 50dc7af into apache:master May 2, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing f prefix on f-strings
3 participants