-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Table chart column config issue #19841
fix: Table chart column config issue #19841
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19841 +/- ##
==========================================
- Coverage 66.55% 66.50% -0.06%
==========================================
Files 1692 1714 +22
Lines 64802 65011 +209
Branches 6657 6717 +60
==========================================
+ Hits 43129 43234 +105
- Misses 19973 20070 +97
- Partials 1700 1707 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
controls: { ...state.controls, [action.controlName]: control }, | ||
controls: { | ||
...state.controls, | ||
[action.controlName]: control, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use controlName
directly here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, we can use it.
Actually this change was made by vsCode auto lint, which means original code was like it. 🤣
* Fix table chart column config issue * resolve comment
* Fix table chart column config issue * resolve comment
SUMMARY
This PR resolved column config issue which happened when we update the chart.
How To Check
Previously changed alignment should be kept in the updated chart.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
[DEV] Add new chart - 25 April 2022 - Watch Video
TESTING INSTRUCTIONS
[DEV] Add new chart - 25 April 2022 - Watch Video
ADDITIONAL INFORMATION