Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Run Applitools on public Storybook #19852

Merged
merged 13 commits into from
May 9, 2022
Merged

feat: Run Applitools on public Storybook #19852

merged 13 commits into from
May 9, 2022

Conversation

geido
Copy link
Member

@geido geido commented Apr 26, 2022

SUMMARY

This PR introduces a Github workflow to test the Storybook Netlify instance nightly (at midnight).

The flow works as follows:

  • Netlify builds a Storybook on every push on master. The built Storybook instance is publicly available here: Superset Storybook. No action is required from our side as Netlify watches the repo and does the build automatically
  • The Github workflow included in this PR will test the Storybook instance nightly at midnight using Applitools

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #19852 (e6da33f) into master (90130e4) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19852      +/-   ##
==========================================
- Coverage   66.56%   66.52%   -0.04%     
==========================================
  Files        1714     1715       +1     
  Lines       65043    65055      +12     
  Branches     6723     6723              
==========================================
- Hits        43293    43278      -15     
- Misses      20037    20066      +29     
+ Partials     1713     1711       -2     
Flag Coverage Δ
javascript 51.26% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rd/components/nativeFilters/FilterBar/keyValue.tsx 33.33% <0.00%> (-18.52%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 60.58% <0.00%> (-7.30%) ⬇️
superset/views/datasource/views.py 90.21% <0.00%> (-6.45%) ⬇️
superset/utils/cache.py 74.52% <0.00%> (-0.48%) ⬇️
superset/sql_lab.py 81.32% <0.00%> (-0.32%) ⬇️
superset/views/core.py 77.02% <0.00%> (-0.04%) ⬇️
superset/models/core.py 89.33% <0.00%> (ø)
superset/db_engine_specs/sqlite.py 97.29% <0.00%> (ø)
superset/charts/commands/importers/v1/__init__.py 100.00% <0.00%> (ø)
superset/models/sql_types/base.py 52.63% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90130e4...e6da33f. Read the comment docs.

@geido geido marked this pull request as draft April 26, 2022 20:03
@geido geido marked this pull request as ready for review April 27, 2022 16:50
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool!

@geido geido merged commit c3ba86e into apache:master May 9, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
* Test storybook workflow

* Add test workflow

* Fix eof

* Update workflow

* Install apt dependencies

* Schedule nightly

* Enhance workflow

* Add secret Applitools key

* Update config

* Add batchName
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* Test storybook workflow

* Add test workflow

* Fix eof

* Update workflow

* Install apt dependencies

* Schedule nightly

* Enhance workflow

* Add secret Applitools key

* Update config

* Add batchName
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants