Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(frontend-tests): Spelling #19853

Merged
merged 24 commits into from
Apr 26, 2022
Merged

chore(frontend-tests): Spelling #19853

merged 24 commits into from
Apr 26, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 26, 2022

SUMMARY

Subset of #19676 per @ktmud

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jsoref
spelling: against
44eeaf0 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: been
f3bc1b0 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: charts
599eb28 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: clicking
3ec5c95 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: columns
fc963e7 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: duplicate
a85717c 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: especially
209a9fc 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: extensions
53a5b0b 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: fields
5f546d0 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: filter
81029b6 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: for
5e1ee0b 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: label
a95f306 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: labeled
f8ac903 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: nativefilter
cdb4960 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: registry
35a8c11 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: render
1f33caa 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: resizable
a05a3a0 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: response
f594ef6 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: successful
c13f82c 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: transform
02fa1be 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: unfortunately
c2aa935 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: until
0faec8a 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: virtual
f2c5e56 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
spelling: wrapper
839fe31 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref jsoref changed the title Spelling frontend test chore(frontend-tests): Spelling Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #19853 (839fe31) into master (c32c505) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19853   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files        1713     1713           
  Lines       64944    64944           
  Branches     6690     6690           
=======================================
  Hits        43173    43173           
  Misses      20067    20067           
  Partials     1704     1704
Flag Coverage Δ
javascript 51.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32c505...839fe31. Read the comment docs.

@ktmud ktmud merged commit bebb10e into apache:master Apr 26, 2022
@jsoref jsoref deleted the spelling-frontend-test branch April 26, 2022 18:44
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
@jsoref
chore(frontend-tests): Spelling (apache#19853)
35dc2f1 
* spelling: against

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: been

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: charts

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: clicking

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: columns

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: duplicate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: especially

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extensions

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fields

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: filter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: for

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: label

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: labeled

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: nativefilter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: registry

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: render

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: resizable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: response

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: successful

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: transform

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unfortunately

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: until

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: virtual

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: wrapper

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@jsoref @philipher29
chore(frontend-tests): Spelling (apache#19853)
ef5595b 
* spelling: against

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: been

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: charts

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: clicking

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: columns

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: duplicate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: especially

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extensions

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fields

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: filter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: for

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: label

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: labeled

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: nativefilter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: registry

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: render

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: resizable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: response

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: successful

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: transform

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unfortunately

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: until

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: virtual

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: wrapper

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktmud ktmud ktmud approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @ktmud @mistercrunch