-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-chart-handlebars): fix overflow, debounce and control reset #19879
Conversation
18bef29
to
db7fd72
Compare
Codecov Report
@@ Coverage Diff @@
## master #19879 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 1714 1714
Lines 65031 65031
Branches 6714 6716 +2
=======================================
Hits 43259 43259
Misses 20065 20065
Partials 1707 1707
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an awesome plugin, a nonblocking cosmetic issue, the template editor seems to break the line too early. the others LGTM
handlebar.mov
Super Cool! LGTM |
apache#19879) * fix(plugin-chart-handlebars): fix overflow * add debounce, fix reset controls * fix deps * remove redundant code * improve examples * add last missing resetOnHides * fix test * use isPlainObject
apache#19879) * fix(plugin-chart-handlebars): fix overflow * add debounce, fix reset controls * fix deps * remove redundant code * improve examples * add last missing resetOnHides * fix test * use isPlainObject
SUMMARY
Add some polish to the new Handlebars plugin:
stringify
helper to make it more convenient to inspect the rows in the data arrayAFTER
handle-after.mp4
BEFORE
handle-before.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION