-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: always create parameter json field #19899
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19899 +/- ##
===========================================
- Coverage 66.44% 54.55% -11.89%
===========================================
Files 1721 1718 -3
Lines 64548 64363 -185
Branches 6811 6742 -69
===========================================
- Hits 42890 35116 -7774
- Misses 19925 27536 +7611
+ Partials 1733 1711 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Outdated
Show resolved
Hide resolved
…ix-onsave-gsheetsdbconn
* fix: always create parameter json field * ensure validation for empty catalog * check engine instead of name * put validation in be * fix test * fix test * remove test
SUMMARY
this pr fixes and issue where the empty catalog for gsheets can be processed as valid in the backend validation method.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Go to dbconnection modal and without entering anything in the fields try hitting saved. It should not allow you to move on to the next step.
TESTING INSTRUCTIONS
after
Screen.Recording.2022-05-02.at.11.00.19.AM.mov
ADDITIONAL INFORMATION