Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Explore data table tooltip #19903

Merged

Conversation

Gwitchr
Copy link
Contributor

@Gwitchr Gwitchr commented Apr 29, 2022

SUMMARY

small style fix so that the copy tooltip is better placed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
image

after
Screen Shot 2022-04-29 at 15 06 11

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #19903 (f6dba72) into master (ad1338f) will increase coverage by 0.00%.
The diff coverage is 70.83%.

❗ Current head f6dba72 differs from pull request most recent head 41c778c. Consider uploading reports for the commit 41c778c to get more accurate results

@@           Coverage Diff           @@
##           master   #19903   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files        1714     1714           
  Lines       65032    65046   +14     
  Branches     6717     6722    +5     
=======================================
+ Hits        43260    43274   +14     
+ Misses      20065    20060    -5     
- Partials     1707     1712    +5     
Flag Coverage Δ
javascript 51.25% <70.58%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/CopyToClipboard/index.jsx 96.00% <ø> (ø)
...d/src/explore/components/DatasourcePanel/index.tsx 69.23% <ø> (ø)
.../components/ExploreAdditionalActionsMenu/index.jsx 57.14% <ø> (ø)
superset/charts/commands/importers/v1/__init__.py 100.00% <ø> (ø)
superset/commands/importers/v1/examples.py 0.00% <ø> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 55.31% <62.50%> (-0.32%) ⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx 37.03% <66.66%> (+0.84%) ⬆️
superset/views/datasource/views.py 96.66% <71.42%> (+6.44%) ⬆️
...re/components/controls/DatasourceControl/index.jsx 72.83% <75.00%> (+0.11%) ⬆️
...set-frontend/src/components/ReportModal/styles.tsx 87.87% <100.00%> (+0.37%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1338f...41c778c. Read the comment docs.

@rusackas rusackas merged commit 7c3fd06 into apache:master May 5, 2022
@Gwitchr Gwitchr deleted the fix/explore-data-table-tool-tip-is-not-point branch May 10, 2022 01:19
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants