feat: deprecate /superset/extra_table_metadata migrate to api v1 #19921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19921 +/- ##
===========================================
- Coverage 66.52% 53.97% -12.56%
===========================================
Files 1714 1714
Lines 65052 65099 +47
Branches 6722 6725 +3
===========================================
- Hits 43279 35139 -8140
- Misses 20061 28248 +8187
Partials 1712 1712
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
May 3, 2022
| @@ -775,10 +775,30 @@ def test_get_invalid_table_table_metadata(self): | |||
| Database API: Test get invalid table from table metadata | |||
| """ | |||
| example_db = get_example_database() | |||
| uri = f"api/v1/database/{example_db.id}/wrong_table/null/" | |||
| uri = f"api/v1/database/{example_db.id}/table/wrong_table/null/" | |||
villebro
reviewed
May 4, 2022
| @@ -415,10 +415,10 @@ describe('async actions', () => { | |||
| fetchMock.delete(updateTableSchemaEndpoint, {}); | |||
| fetchMock.post(updateTableSchemaEndpoint, JSON.stringify({ id: 1 })); | |||
|
|
|||
| const getTableMetadataEndpoint = 'glob:*/api/v1/database/*'; | |||
| const getTableMetadataEndpoint = 'glob:**/api/v1/database/*/table/*/*/'; | |||
There was a problem hiding this comment.
isn't a single asterisk here sufficient?
Suggested change
| const getTableMetadataEndpoint = 'glob:**/api/v1/database/*/table/*/*/'; | |
| const getTableMetadataEndpoint = 'glob:*/api/v1/database/*/table/*/*/'; |
| fetchMock.get(getTableMetadataEndpoint, {}); | ||
| const getExtraTableMetadataEndpoint = | ||
| 'glob:*/superset/extra_table_metadata/*'; | ||
| 'glob:**/api/v1/database/*/table_extra/*/*/'; |
There was a problem hiding this comment.
Same here
Suggested change
| 'glob:**/api/v1/database/*/table_extra/*/*/'; | |
| 'glob:*/api/v1/database/*/table_extra/*/*/'; |
villebro
approved these changes
May 4, 2022
dpgaspar
deleted the
danielgaspar/sc-42066/migrate-superset-extra-table-metadata-database
branch
jasonvank
pushed a commit
to CarbonEdge2021/superset
that referenced
this pull request
May 4, 2022
…che#19921) * feat: deprecate /superset/extra_table_metadata migrate to api v1 * use can_read to table_extra_metadata * troubleshoot sqlite * fix test * fix test * fix test * fix frontend test on sqllab
jasonvank
pushed a commit
to CarbonEdge2021/superset
that referenced
this pull request
May 4, 2022
…che#19921) * feat: deprecate /superset/extra_table_metadata migrate to api v1 * use can_read to table_extra_metadata * troubleshoot sqlite * fix test * fix test * fix test * fix frontend test on sqllab
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
…che#19921) * feat: deprecate /superset/extra_table_metadata migrate to api v1 * use can_read to table_extra_metadata * troubleshoot sqlite * fix test * fix test * fix test * fix frontend test on sqllab
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…che#19921) * feat: deprecate /superset/extra_table_metadata migrate to api v1 * use can_read to table_extra_metadata * troubleshoot sqlite * fix test * fix test * fix test * fix frontend test on sqllab
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following plan to gradually deprecate "REST" endpoints on /superset namespace.
Deprecates
/superset/extra_table_metadata/<int:database_id>/<table_name>/<schema>/. Proposed removal on Superset 3.0New endpoint
/api/v1/database/<int:database_id>/table_extra/<table_name>/<schema_name>/BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION