fix: memoize primitives #19930
Merged
fix: memoize primitives #19930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
dont_cache_namedtuples
branch
from
742bf57
to
a7ce679
Compare
Codecov Report
@@ Coverage Diff @@
## master #19930 +/- ##
==========================================
- Coverage 66.53% 66.51% -0.03%
==========================================
Files 1715 1715
Lines 65060 65060
Branches 6723 6723
==========================================
- Hits 43289 43274 -15
- Misses 20060 20075 +15
Partials 1711 1711
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AAfghahi
approved these changes
May 2, 2022
eschutho
reviewed
May 2, 2022
| In the example above the result for `1+2` will be stored under the key of name "1+2", | ||
| in the `cache_manager.data_cache` cache. | ||
|
|
||
| Note: this decorator should be used only with functions that return primitives, |
eschutho
approved these changes
May 2, 2022
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
May 2, 2022
(cherry picked from commit 1ebdaac)
|
🏷️ preset:2022.17 |
eschutho
reviewed
May 2, 2022
| schema=schema, | ||
| force=True, | ||
| cache=database.table_cache_enabled, | ||
| cache_timeout=database.table_cache_timeout, |
There was a problem hiding this comment.
@beto what would happen if this value returns from cache prior to this change and it's not a list of strings but rather the DatasourceName object?
There was a problem hiding this comment.
Great question, the cool thing about this solution is that it still works with old cached values:
>>> from typing import NamedTuple
>>>
>>> class DatasourceName(NamedTuple):
... table: str
... schema: str
...
>>> a = DatasourceName(table='t', schema='s')
>>> DatasourceName(*a)
DaasourceName(table='t', schema='s')
9 tasks
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In some of the views we're caching
DatasourceNamenamedtuples to Redis using thememoized_funcdecorator. We found that in certain cases the object that comes back from the cache is a list of[table, schema], instead ofDatasourceName(table=table, schema=schema), which breaks the view.I changed the code in
models/core.pyso that the return value from the memoized functions is a primitive (a tuple of(table, schema)), and we rebuild the namedtuple inviews/core.py, to prevent this bug from happening.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Updated unit tests.
ADDITIONAL INFORMATION